[PATCH] D34830: [lit, test-suite] Fix a reference to FileBasedTest that I missed earlier.

[David L. Jones via Phabricator via llvm-commits]

dlj created this revision.
Herald added a subscriber: sanjoy.

The test-suite implements its own specialized lit format for running tests,
which was based on FileBasedTest. Since that base was removed, the format now
needs to use something that is still available.

The only functionality that comes from FileBasedTest is the test discovery,
which was moved into ShTest. For now, it seems to make the most sense simply to
use ShTest as the base for TestSuiteTest.

I think a better solution is to factor out the test discovery logic, although
that will require a bit more work (and has effects across projects).


https://reviews.llvm.org/D34830

Files:
  litsupport/test.py


Index: litsupport/test.py
===================================================================
--- litsupport/test.py
+++ litsupport/test.py
@@ -7,7 +7,7 @@
 import lit.util
 import logging
 import os
-from lit.formats import FileBasedTest
+from lit.formats import ShTest
 from lit.TestRunner import getTempPaths
 from lit import Test
 from lit.util import to_bytes, to_string
@@ -59,7 +59,7 @@
         modules.append(module)
 
 
-class TestSuiteTest(FileBasedTest):
+class TestSuiteTest(ShTest):
     def __init__(self):
         super(TestSuiteTest, self).__init__()
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34830.104719.patch
Type: text/x-patch
Size: 571 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170629/85c946ee/attachment.bin>