[PATCH] D34647: [opt-viewer] Python 3 support in opt-viewer.py

[Adam Nemet via Phabricator via llvm-commits]

anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

LGTM, one suggestion below.



================
Comment at: utils/opt-viewer/opt-viewer.py:193-195
+        sorted_remarks = sorted(optrecord.itervalues(all_remarks), key=lambda r: (r.Hotness, r.File, r.Line, r.Column, r.PassWithDiffPrefix, r.yaml_tag, r.DemangledFunctionName), reverse=True)
     else:
+        sorted_remarks = sorted(optrecord.itervalues(all_remarks), key=lambda r: (r.File, r.Line, r.Column, r.PassWithDiffPrefix, r.yaml_tag, r.DemangledFunctionName))
----------------
Can we use r.Function to avoid calling the demangler?


https://reviews.llvm.org/D34647