[PATCH] D34817: [SimplifyCFG] Update the name of switch generated lookup table.

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 10:29:38 PDT 2017


hans added a comment.

Thanks! This seems useful also for nicer test files.



================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:4836
 SwitchLookupTable::SwitchLookupTable(
-    Module &M, uint64_t TableSize, ConstantInt *Offset,
+    Module &M, const Function &F, uint64_t TableSize, ConstantInt *Offset,
     const SmallVectorImpl<std::pair<ConstantInt *, Constant *>> &Values,
----------------
Could you change this to pass in a StringRef to the function name instead? That way the reader doesn't have to wonder what it needs the Function for.


Repository:
  rL LLVM

https://reviews.llvm.org/D34817





More information about the llvm-commits mailing list