[PATCH] D34627: [Power9] Disable removing extra swaps on P9 since it should not be needed.

Tony Jiang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 09:47:22 PDT 2017


jtony added inline comments.


================
Comment at: lib/Target/PowerPC/PPCTargetMachine.cpp:371
   if (TM->getTargetTriple().getArch() == Triple::ppc64le &&
+      !TM->getSubtargetImpl()->isISA3_0() &&
       !DisableVSXSwapRemoval)
----------------
nemanjai wrote:
> inouehrs wrote:
> > I feel it is better to use `Subtarget.needsSwapsForVSXMemOps()` to make the meaning of the check clearer.
> This is actually a really good point. I forgot that we added that function. Please use that instead.
I agree with Hiroshi, this is a good way to increase code readability. 


https://reviews.llvm.org/D34627





More information about the llvm-commits mailing list