[PATCH] D34704: [DWARF] NFC: Combine relocs with DataExtractor

[Paul Robinson via Phabricator via llvm-commits]

probinson marked an inline comment as done.
probinson added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFUnit.h:200-203
+  DWARFDataExtractor getDebugInfoExtractor() const {
+    return DWARFDataExtractor(InfoSection, isLittleEndian,
+                              getAddressByteSize());
   }
----------------
probinson wrote:
> dblaikie wrote:
> > Was the original code incorrect here? (since it wasn't using relocs for whoever was calling it previously? Or have those callers been using getRelocated* and have been migrated by this change?)
> The latter.  In fact before I did this, I had tripped over a case where I incorrectly attached the .debug_line relocations to a use of .debug_line.dwo, and this turned out to be a good refactoring to avoid that kind of mistake.
Duh, not .debug_line.dwo, but .debug_types.dwo got relocations incorrectly.  Anyway, commit coming as soon as the test run finishes.


https://reviews.llvm.org/D34704