[PATCH] D33680: [ELF] - Resolve references properly when using .symver directive

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/SymbolTable.cpp:742-743
+    // but also undefined unversioned symbols with name <name>.
+    SymbolBody *Old = find(Body->getName());
+    if (Old && Old->isUndefined()) {
+      auto *D = cast<DefinedRegular>(Body);
----------------
ruiu wrote:
> Old doesn't sound like a good name as it is not an old symbol. Since the scope of this variable is very small, just S would be enough.
Done.


================
Comment at: ELF/SymbolTable.cpp:745-746
+      auto *D = cast<DefinedRegular>(Body);
+      addRegular(D->getName(), D->StOther, D->Type, D->Value, D->Size,
+                 D->symbol()->Binding, D->Section, D->File);
+    }
----------------
ruiu wrote:
> I added Symbol::copyBody, so please use that function.
Done.


https://reviews.llvm.org/D33680