[PATCH] D34032: [Power9] Exploit vector extract with variable index

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: test/CodeGen/PowerPC/vec_extract_p9.ll:117
+; CHECK-LE:       # BB#0: # %entry
+; CHECK-LE-NEXT:    li 3, 1
+; CHECK-LE-NEXT:    vextubrx 3, 3, 2
----------------
stefanp wrote:
> This is probably fine. I have more of a question here...
> I see that throughout the tests (not just here) the registers used are specified. 
> While the register allocator is most likely to pick r3 in this case is that a guarantee? The load immediate is not constrained by the ABI so technically it could use a different register and this is still correct. 
The CHECK directives were produced by a script (see the first line in the test case). The choices register allocator makes should be fairly consistent so this should be fine.


https://reviews.llvm.org/D34032