[PATCH] D34197: Added Dockerfiles to build clang from sources.

Ilya Biryukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 01:06:55 PDT 2017


ilya-biryukov added inline comments.


================
Comment at: docs/Docker.rst:109
+(``llvm/utils/build_clang_image.sh``) that handles that. It has less parameters
+and be used like that:
+
----------------
mehdi_amini wrote:
> It is very confusing why we need three scripts. I especially don't understand the introduction of the build_clang_image.sh script here.
> Can we just get rid of this third script that (after looking at the code) is a thing wrapper and just give the example invocation of the build_docker_image.sh that does that?
It is indeed just a thin wrapper with a sole purpose of including a proper "recipe" to do a 2-stage clang build.
Is there any harm in including it? It's a very small and simple script. Do you find it confusing to have it beside the main script to build docker images?



https://reviews.llvm.org/D34197





More information about the llvm-commits mailing list