[PATCH] D34793: [lit] Fix some convoluted logic around Unicode encoding, and de-duplicate across modules that used it.

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 21:39:02 PDT 2017


dlj added a comment.

In https://reviews.llvm.org/D34793#794765, @dlj wrote:

> In https://reviews.llvm.org/D34793#794757, @chapuni wrote:
>
> > Seems incompatible to py3.
> >  http://bb.pgr.jp/builders/test-llvm-i686-linux-RA/builds/3747
> >
> > I am investigating. Excuse me if I would revert this.
>
>
> Sorry for the trouble, reverted.


I re-applied this in r306643. There are some tests that simply yield binary output, and I was missing a conversion in googletest. I verified with Python 2.7 and Python 3.4.3, both on Linux.


Repository:
  rL LLVM

https://reviews.llvm.org/D34793





More information about the llvm-commits mailing list