[PATCH] D34620: [DataLayout] Remove default argument from DataLayout APIs

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 19:19:29 PDT 2017


chandlerc added a comment.

This isn't really the meaning of the FIXME.

The issues is that at each call site we actually need to do careful analysis to understand what the address space should be and only move away from the default argument when we understand the *correct* address space for a particular call site.

This way, the default argument serves as a marker for when a caller hasn't yet been updated to carefully consider the address space implications.

That means this can't just be a cleanup. =/


https://reviews.llvm.org/D34620





More information about the llvm-commits mailing list