[PATCH] D34792: [lit] Remove dead code not referenced in the LLVM SVN repo.

[David L. Jones via Phabricator via llvm-commits]

dlj added inline comments.


================
Comment at: utils/lit/lit/formats/base.py:21
+    implemented.
+    """
+
----------------
modocache wrote:
> I greatly appreciate the documentation here. Thanks!
Glad it helps!


================
Comment at: utils/lit/lit/formats/shtest.py:24
+
+        The 'execute_external' argument controls whether Lit uses its internal
+        logic for command pipelines, or passes the command to a shell
----------------
modocache wrote:
> Question: The documentation for lit spells it with a lowercase 'l': http://llvm.org/docs/CommandGuide/lit.html. http://llvm.org/docs/TestingGuide.html, on the other hand, uses both capital and lowercase in some places. Which is correct?
> 
> I had always thought that lowercase "lit" was the proper name. If you agree, then this line and the "Args" section below should be updated.
I think I agree more with your logic... this was probably a typo, after typing LitConfig so many times.


https://reviews.llvm.org/D34792