[PATCH] D34792: [lit] Remove dead code not referenced in the LLVM SVN repo.

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 17:33:15 PDT 2017


dlj created this revision.
Herald added a subscriber: sanjoy.

This change removes the intermediate 'FileBasedTest' format from lit. This
format is only ever used by the ShTest format, so the logic can be moved into
ShTest directly.

In order to better clarify what the TestFormat subclasses do, I fleshed out the
TestFormat base class with Python's notion of abstract methods, using
@abc.abstractmethod. This gives a convenient way to document the expected
interface, without the risk of instantiating an abstract class (that's what
ABCMeta does -- it raises an exception if you try to instantiate a class which
has abstract methods, but not if you instantiate a subclass that implements
them).


https://reviews.llvm.org/D34792

Files:
  utils/lit/lit/formats/__init__.py
  utils/lit/lit/formats/base.py
  utils/lit/lit/formats/shtest.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34792.104553.patch
Type: text/x-patch
Size: 8863 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170629/a172e48c/attachment.bin>


More information about the llvm-commits mailing list