[PATCH] D34730: [AArch64] Make assert messages uniform [NFC]

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 12:18:20 PDT 2017


mgrang added a comment.

In https://reviews.llvm.org/D34730#793309, @t.p.northover wrote:

> I'd be pretty tempted to remove them entirely. Those are the only 3 LLVM supports at all and assertions for (extremely) hypothetical future additions seem to be taking it a bit far.


I think these messages are useful when adding new targets. The only thing is we would need to keep changing the messages to include every new target added. So I have made the messages more generic.


Repository:
  rL LLVM

https://reviews.llvm.org/D34730





More information about the llvm-commits mailing list