[PATCH] D34764: Introduce FileEdit utility

[David Blaikie via llvm-commits]

On Wed, Jun 28, 2017 at 10:47 AM Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk added a comment.
>
> The tests in llvm/test/tools/llvm-symbolizer are a good place to use this.
> See the ADDR: sed+grep pattern I used to extract some hex numbers from the
> file.
>

For myself, that doesn't motivate this feature compared to the
test/DebugInfo/llvm-symbolizer.test file that contains a bunch of echo
lines. It's nice, for sure, but doesn't do a lot for me (& if removing the
syntactic overhead of "RUN: echo 0xXXXX >> %t.input" (to "ADDR: 0xXXXX")
was important, it could be put in a separate file - not like the addresses
add a lot of meaningful context to the test file. They're pretty much
arbitrary/magic numbers (necessarily, not intended as a criticism by any
means).


>
>
> https://reviews.llvm.org/D34764
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170628/98a85191/attachment.html>