[PATCH] D34744: [DWARF] - Simplify HandleExpectedError implementation in DWARFDebugInfoTest

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 28 08:10:05 PDT 2017


zturner added inline comments.


================
Comment at: unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp:102
   auto ExpectedDG = dwarfgen::Generator::create(Triple, Version);
   if (HandleExpectedError(ExpectedDG))
     return;
----------------
I recently added some functions to llvm that server this purpose better.  I would suggest just deleting this function, and adding this:

```
#include "llvm/Testing/Support/Error.h"
...
ASSERT_THAT_EXPECTED(ExpectedDG, Succeeded());
```


https://reviews.llvm.org/D34744





More information about the llvm-commits mailing list