[PATCH] D32994: [NFC] Use stdin for some tests instead of positional argument.

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D32994#793690, @a.elovikov wrote:

> In https://reviews.llvm.org/D32994#793670, @spatel wrote:
>
> > Remove the '-o -' too?
> >
> > Just curious: why only these files? The problem occurs in hundreds of tests from what I can tell. Shouldn't we fix all of them?
>
>
> I have my compiler built in a `cmplr/` directory which matches the `CHECK-NOT: cmp` check in these tests.


Ah, right...CHECK-NOT is a poor way to verify output. Note that at least some ARM/Thumb triples are supported by utils/update_llc_test_checks.py, so a good follow-up patch would be to remove the current CHECK lines and let the script add complete checking (with no CHECK-NOT).

LGTM.


https://reviews.llvm.org/D32994