[PATCH] D33948: Try to handle 'dla' in PIC mode for N64.

[John Baldwin via Phabricator via llvm-commits]

bsdjhb marked 6 inline comments as done.
bsdjhb added inline comments.


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:2868
     // constant then we must use R_MIPS_CALL16 instead of R_MIPS_GOT16.
-    if ((DstReg == Mips::T9 || DstReg == Mips::T9_64) && !UseSrcReg &&
+    if (DstReg == Mips::T9 && !UseSrcReg &&
         Res.getConstant() == 0 && !(Res.getSymA()->getSymbol().isInSection() ||
----------------
sdardis wrote:
> Can you remove that change?
> 
> The expansion for 'la' and 'dla' in the PIC case are very similar. I'd like both chunks of code to be as similar as possible so that the refactoring is as easy as possible.
Do you want me to check for both T9 and T9_64 in the new 64-bit block as well?


https://reviews.llvm.org/D33948