[PATCH] D34720: Hook the sample PGO machinery in the new PM

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 16:00:10 PDT 2017


On Tue, Jun 27, 2017 at 3:54 PM, Dehao Chen via Phabricator <
reviews at reviews.llvm.org> wrote:

> danielcdh added a comment.
>
> In https://reviews.llvm.org/D34720#792993, @davidxl wrote:
>
> > One or more integration test (using clang driver with new PM) is
> probably needed.
>
>
> The test is added in the clang side: https://reviews.llvm.org/D34721
>
>

Is that test good enough to catch most of the expected bahavior with the
pipeline? (e.g,  hot callsite from hot inline instance chain)? This will
help prevent accidental pipeline change that affects autoFDO.  Probably in
a different patch.

David

>
> https://reviews.llvm.org/D34720
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170627/471584a5/attachment.html>


More information about the llvm-commits mailing list