[PATCH] D33001: [RuntimeUnrolling] Add logic for loops with multiple exit blocks
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 27 14:29:23 PDT 2017
reames added a comment.
Anna and I talked offline because I was having trouble understanding the intent of the new code. She's going to update a revised version which will address the cause of my confusion.
================
Comment at: lib/Transforms/Utils/LoopUnrollRuntime.cpp:293
/// new loop exit.
///
+static Loop *
----------------
Update the comment to describe the return value please.
================
Comment at: lib/Transforms/Utils/LoopUnrollRuntime.cpp:764
+ PHINode *OldPHI = cast<PHINode>(&II);
+ SmallVector<BasicBlock*, 8> OrigLoopBlocks;
+ SmallVector<Value*, 8> OrigLoopValues;
----------------
Dead variables?
https://reviews.llvm.org/D33001
More information about the llvm-commits
mailing list