[PATCH] D34664: Add more stringent tests for the resource section of executables.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/test/COFF/Inputs/test_resource.rc:51
+}
\ No newline at end of file

----------------
Fix



================
Comment at: lld/test/COFF/combinedresources.test:1
+// Check that lld properly handles merging multiple .res files.
+// The inputs were generated with the following commands, using the original
----------------
Rename this file to combined-resources.test as separating words using hyphens is a local convention in this directory.


================
Comment at: lld/test/COFF/combinedresources.test:4
+// Windows rc.exe
+// > rc /fo test_resource.res /nologo test_resource.rc
+// > rc /fo languages.res /nologo languages.rc
----------------
Please rename test_resources.res combined-resources.test as using the same name is a local convention too.


================
Comment at: lld/test/COFF/combinedresources.test:22
+CHECK-NEXT:   Total Number of Resources: 13
\ No newline at end of file

----------------
Please fix.


https://reviews.llvm.org/D34664