[PATCH] D34644: Only test sanitizers that are built when COMPILER_RT_SANITIZERS_TO_BUILD is used

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

I don't understand why we have this `COMPILER_RT_SANITIZERS_TO_BUILD` feature, but given that we have it, this seems reasonable to me.



================
Comment at: test/CMakeLists.txt:66
+    compiler_rt_test_runtime(lsan)
+    compiler_rt_test_runtime(ubsan cfi)
+    compiler_rt_test_runtime(sanitizer_common)
----------------
I guess if you want this to be controlled by `COMPILER_RT_SANITIZERS_TO_BUILD` it would need to be calling `compiler_rt_test_sanitizer`.


================
Comment at: test/CMakeLists.txt:72
-    endif()
-    # CFI tests require diagnostic mode, which is implemented in UBSan.
-    if(COMPILER_RT_HAS_UBSAN)
----------------
Probably want to preserve this comment.


https://reviews.llvm.org/D34644