[PATCH] D34658: [WebAssembly] Add support for printing relocations with llvm-objdump

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:1085
     return getRelocationValueString(ELF, Rel, Result);
-  if (auto *COFF = dyn_cast<COFFObjectFile>(Obj))
+  else if (auto *COFF = dyn_cast<COFFObjectFile>(Obj))
     return getRelocationValueString(COFF, Rel, Result);
----------------
dschuff wrote:
> LLVM style is "don't use else after return" (http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return)
BTW I do like that you're adding the error case on fall though; I guess you could pretty much just remove all the elses and leave the ifs, and get the same thing.


https://reviews.llvm.org/D34658