[PATCH] D34063: [ThinLTO] YAML traits for module summaries

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: test/tools/llvm-lto2/X86/dump-summary-yaml.ll:14
+; CHECK:       Calls:
+; CHECK:         - GUID:
+; CHECK:           Hotness:         Unknown
----------------
ncharlie wrote:
> tejohnson wrote:
> > For the lines that have names, can you check for the names as well? You could either put in the expected GUID value, or use a regex to accept any GUID #. The FileCheck regex format for matching anything is: {{.*}}
> Added the regex to match the GUIDs now. 
> 
> I didn't check for names, because the current llvm-lto2 pass won't print them out, because it needs to pass in a special struct with that includes a Module pointer for the name. Since the llvm-lto2 dump summary patch doesn't support the struct yet (as it's in this patch), I didn't enable the names in the other patch yet. I'll need to create another patch once both these patches are merged in so llvm-lto2 prints the names in the summary.
I think the other patch is approved, and can go in now. Then since you are adding the name mapping functionality in this patch, I would say go ahead and add the llvm-lto2 name dumping in this patch.


https://reviews.llvm.org/D34063