[PATCH] D34661: Fix for pr30418 - error in backend: Cannot select: t17: x86mmx = select_cc t2, Constant:i64<0>, t7, t8, seteq:ch

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

Thanks for looking at this!

Very minor, but can you make sure that the patch title is something like "[X86][MMX] Added custom lowering action for MMX SELECT (PR30418)" and then make your current title the summary - it makes finding reviews/commits easier.



================
Comment at: test/CodeGen/X86/pr30418.ll:5
+
+define i64 @test47(i64) local_unnamed_addr #1 {
+  %2 = icmp eq i64 %0, 0
----------------
If possible, we need better test coverage here. Please can you rename the file select-mmx.ll, rename this test pr30418 and add filecheck and update_llc_test_checks.py codegen generation.

You also need to test on a i686 triple as well since you're creating i64 values.

A few extra tests wouldn't go amiss - select with non-constant mmx values for instance.


https://reviews.llvm.org/D34661