[PATCH] D34579: Fold fneg and fabs like multiplications

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 03:12:15 PDT 2017


vpykhtin accepted this revision.
vpykhtin added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9767
+
+    if (True && False &&
+        Cond.getOpcode() == ISD::SETCC && Cond.getOperand(0) == X &&
----------------
I understand what you meant but at first glance it looks like "if ( 2 * 2 == 4 )" :-) Should it be named like TrueOpnd and FalseOpnd?


https://reviews.llvm.org/D34579





More information about the llvm-commits mailing list