[PATCH] D34504: [LLVM][X86][Goldmont] Adding new target-cpu: Goldmont

Igor Breger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 27 01:34:42 PDT 2017


igorb added a comment.

In https://reviews.llvm.org/D34504#790951, @craig.topper wrote:

> Should we OR in isGLM() every place we use isSLM() today?
>
> @zvi or @igorb Should all the places that use isAtom() also include isSLM() and isGLM()? Should isAtom() be renamed to isBonnell()? isAtom sounds like it implies any Atom processor, but it really doesn't.


Hello Craig,
I think this patch should  focus on functionality only . All performance related issues may be resolved as separate patches following careful study of Intel optimization manual.
https://software.intel.com/sites/default/files/managed/9e/bc/64-ia-32-architectures-optimization-manual.pdf


https://reviews.llvm.org/D34504





More information about the llvm-commits mailing list