[PATCH] D34258: [Dominators] Use Semi-NCA instead of SLT to calculate dominators

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 18:51:11 PDT 2017


dberlin accepted this revision.
dberlin added a comment.
This revision is now accepted and ready to land.

Given we haven't found anything fuzzing wise, i think it's fine to land this, but let's watch out for performance regressions and be ready to revert if we need to.



================
Comment at: include/llvm/Support/GenericDomTreeConstruction.h:209
+    while (DT.Info[WIDomCandidte].DFSNum > SDomNum)
+      WIDomCandidte = DT.IDoms[WIDomCandidte];
+
----------------
Typo: should be WIDomCandidate


Repository:
  rL LLVM

https://reviews.llvm.org/D34258





More information about the llvm-commits mailing list