[PATCH] D34655: [AMDGPU] Add 2 new alignbit patterns

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: test/CodeGen/AMDGPU/alignbit-pat.ll:18
+}
+
+; GCN-LABEL: {{^}}alignbit_shl_pat:
----------------
arsenm wrote:
> Needs negative tests with different values for the constants etc.
> 
> Also tests where src1 is a VGPR vs. SGPR
I'm not sure what kind of negative test do you want to see here? Pattern is only valid in presence of "& 31", and then matches always.


https://reviews.llvm.org/D34655