[PATCH] D33186: [InstCombine] Canonicalize clamp of float types to minmax in fast mode.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 17:12:18 PDT 2017


efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:1329
+          (CmpLHS != LHS && CmpLHS != RHS) ||
+          (CmpRHS != LHS && CmpRHS != RHS)) {
         CmpInst::Predicate Pred = getCmpPredicateForMinMax(SPF, SPR.Ordered);
----------------
This change isn't guarded for floating-point operations in particular... does this have an impact on integer clamp?  If not, why?


https://reviews.llvm.org/D33186





More information about the llvm-commits mailing list