[PATCH] D33964: [LLVM][llvm-objcopy] Added basic plumbing to get things started

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 26 16:04:04 PDT 2017


jakehehrlich updated this revision to Diff 104037.
jakehehrlich set the repository for this revision to rL LLVM.
jakehehrlich added a comment.

In working on some more other features and improvements to this I realized that I had dangling pointer issue. I was assigning pointers to Segments out of an std::vector. These pointers would become invalid on resize. To fix this I simply used unique pointers to store the segments. The code changed very little as a result since I try my best not to mess with program headers.


Repository:
  rL LLVM

https://reviews.llvm.org/D33964

Files:
  test/tools/llvm-objcopy/basic-copy.test
  tools/LLVMBuild.txt
  tools/llvm-objcopy/CMakeLists.txt
  tools/llvm-objcopy/LLVMBuild.txt
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h
  tools/llvm-objcopy/llvm-objcopy.cpp
  tools/llvm-objcopy/llvm-objcopy.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33964.104037.patch
Type: text/x-patch
Size: 20598 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170626/fffd3ab0/attachment-0001.bin>


More information about the llvm-commits mailing list