[PATCH] D34448: bug33527 - Linker::LinkOnlyNeeded should import AppendingLinkage globals

[Benoit Belley via Phabricator via llvm-commits]

belleyb marked an inline comment as done.
belleyb added inline comments.


================
Comment at: unittests/Linker/LinkModulesTest.cpp:402
+  // Intrisic global variables must be imported since the
+  // ImportIntrinsicGlobalVariables flag has been specified.
+  auto const *ctor1 = Dst->getFunction("ctor1");
----------------
tejohnson wrote:
> There are a number of references in the unit test to this flag, which looks like it was from an old approach you were considering, but not actually using here. Although I guess this comment is moot if you transition to using lit/FileCheck based tests...
Good catch. The llmv-link + FileCheck test will replace all of that...


https://reviews.llvm.org/D34448