[PATCH] D34135: [LVI] Add initial result to avoid infinite getValueFromCondition recursion

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

In https://reviews.llvm.org/D34135#782084, @uabelho wrote:

> Great discussion guys!
>
> So if I try to summarize:
>
> - Everyone agrees the real fix would be to rewrite JT, but no one has the time to do it.
> - There are probably many more problems in JT just waiting to be exposed.
> - The patch doesn't make things worse.
> - No one objects if we put this patch in.
>
>   Did I get it right?
>
>   Another question: Does anyone have an opinion about if the initial inserted value should be "overdefined" (as currently in the patch) or if it should be "undefined"? Does it even matter?
>
>   My choice of "overdefined" was simply because there existed a LVILatticeVal::getOverdefined() method. It's not the result of a great deal of analysis.


Ping!

Any more comments on this?

What about "overdefined" vs "undefined"?

Anyone wants to accept it or should we let it be broken?


https://reviews.llvm.org/D34135