[PATCH] D34285: [SROA] Be smarter when copying metadata to retyped loads

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added inline comments.


================
Comment at: include/llvm/Transforms/Utils/Local.h:383
 
+/// Copy metadata from load instructions between load instructions.
+///
----------------
I have no idea what this comment is trying to say ;)



================
Comment at: include/llvm/Transforms/Utils/Local.h:385
+///
+///     sameValue - copy metadata about the value (!nonnull, !range)
+///     sameAddress - copy metadata about the address (!noalias, !invariant, etc.)
----------------
By value do you mean "result"?

IE the result of the load?

If so, please use that, as it's much clearer.
Loads don't have values, they have addresses, and results.



https://reviews.llvm.org/D34285