[PATCH] D34538: Handle ConstantExpr correctly in SelectionDAGBuilder

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 23 13:26:57 PDT 2017


RKSimon added reviewers: davide, RKSimon.
RKSimon added inline comments.


================
Comment at: test/CodeGen/Generic/pr33094.ll:2
+; RUN: llc < %s
+
+%A = type {}
----------------
efriedma wrote:
> Needs a comment describing what it's testing.
> 
> Writing tests without any CHECK lines is usually a bad idea, because they tend to be very easy to break, but I'm not sure what we would want to check for here, exactly, so I guess this is okay.
Shouldn't this at least include a REQUIRES: asserts?


https://reviews.llvm.org/D34538





More information about the llvm-commits mailing list