-load-combine status request

Michael Spencer via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 22 15:14:59 PDT 2017


On Wed, Jun 21, 2017 at 11:31 AM, Davide Italiano <davide at freebsd.org>
wrote:

> I remembered about this after we got a report this morning
> https://bugs.llvm.org/show_bug.cgi?id=33544
> Almost two years later, we're in the same situation.
> Also, I'm aware some work in the backend has been done to catch cases
> that LC was supposed to catch.
> Michael, do you have plans for this?
>
> --
> Davide
>
> On Thu, Sep 24, 2015 at 10:53 PM, Eric Christopher via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Okay, thanks for the update.
> >
> >
> > On Thu, Sep 24, 2015, 10:34 PM Michael Spencer <bigcheesegs at gmail.com>
> > wrote:
> >>
> >> On Thu, Sep 24, 2015 at 12:12 PM, Eric Christopher <echristo at gmail.com>
> >> wrote:
> >> > Hi Michael,
> >> >
> >> >>
> >> >> > I notice that the -load-combine pass is not being used since its
> >> >> > initial
> >> >> > commit in r209791.
> >> >> > What's the status on this? Should it be removed? Are there any plan
> >> >> > to
> >> >> > use
> >> >> > it at some point in the future?
> >> >> >
> >> >> > Thanks,
> >> >> > -- Larisse.
> >> >>
> >> >> It's waiting for a machine pass to do load slicing to be enabled by
> >> >> default. I've been planning on doing this, but it's not going to
> >> >> happen soon.
> >> >>
> >> >
> >> > So, what would you like to do then? :)
> >> >
> >> > It's been pretty much dead code since it was committed more than a
> year
> >> > ago
> >> > and we try to avoid keeping dead code in tree. It's not a ton of work
> to
> >> > keep it updated, but that's all that's happened to the pass in the
> mean
> >> > time
> >> > and we don't have any idea when it might be usable.
> >> >
> >> > Thoughts?
> >> >
> >> > -eric
> >>
> >> So it actually appears that someone has written a load slicer since
> >> that went in. I'll figure out next week if it fixes the performance
> >> problems I was encountering before and hopefully turn it on. If not
> >> I'm fine with removing it.
> >>
> >> - Michael Spencer
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >
>
>
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
>

I have no plans any time soon. I'm fine removing it. It's still in the
history if anyone ever wants to revive it.

- Michael Spencer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170622/2432c3fd/attachment.html>


More information about the llvm-commits mailing list