[PATCH] D34446: [Support] sys::getProcessTriple should return a macOS triple using the system's version of macOS

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 21 15:04:07 PDT 2017


dexonsmith added a comment.

> Right now, `sys::getProcessTriple` returns the `LLVM_HOST_TRIPLE`, whose system version might not be the actual version of the system on which the compiler running.

Are we sure no one depends on that behaviour?

> I'm not sure if it's possible to test this change (Please let me know if I'm wrong though).

I think we could add a lit test with `REQUIRES: shell` that only runs on macOS and uses `sw_vers` to pull out the system OS version.  If any builder has a non-matching `LLVM_HOST_TRIPLE`, we have some test coverage.


Repository:
  rL LLVM

https://reviews.llvm.org/D34446





More information about the llvm-commits mailing list