[PATCH] D34387: [PATCH 2/2] Implement "probe-stack" on x86

[David Majnemer via Phabricator via llvm-commits]

majnemer added a comment.

In https://reviews.llvm.org/D34387#787200, @pcwalton wrote:

> Addressed review comments.
>
> I removed the R11 spill code as requested. I left in the refactoring that moves the existing EAX spill and reload code into separate functions, as `X86FrameLowering::emitPrologue()` is rather large and that seemed like a worthwhile refactoring.


I am not entirely sure that the refactored code is identical to what was left behind. Moreover, the refactoring is now incidental with respect to the bulk of the change. I'd request that if you were to pursue it, to please factor it out into another review.


https://reviews.llvm.org/D34387