[PATCH] D34452: Implement the ".rdata" MIPS assembly directive.

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM. .rdata is the SGI pseudo op equivalent of the ELF .rodata.

Nit: The test should be in test/MC/Mips/mips-rdata.s

The SHF_MIPS_GPREL flag is set when a section is called "srdata" but there is no pseudo-op support for that. That's irrelevant to this patch though.

Do you need me to commit this for you?



================
Comment at: test/CodeGen/Mips/mips-rdata.s:1-13
+# Check that .rdata sections have proper name, flags, and section types.
+
+# RUN: llvm-mc -filetype=obj -triple=mips-unknown-linux %s -o - \
+# RUN:   | llvm-readobj -s | FileCheck %s
+
+  .rdata
+  .word 0
----------------
This file belongs in test/MC/Mips/mips-rdata.s


https://reviews.llvm.org/D34452