[PATCH] D34423: Create TD nodes for ADDCARRY and SUBCARRY opcodes

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 16:47:53 PDT 2017


arsenm added inline comments.


================
Comment at: include/llvm/Target/TargetSelectionDAG.td:161
+def SDTCarryOp : SDTypeProfile<2, 3, [      // addcarry, subcarry
+  SDTCisSameAs<0, 2>, SDTCisSameAs<0, 3>, SDTCisInt<0>, SDTCisVT<1, i1>, SDTCisVT<4, i1>
+]>;
----------------
i1 is wrong here since it will presumably be legalized to the target's boolean contents at some point, which won't necessarily be i1.


Repository:
  rL LLVM

https://reviews.llvm.org/D34423





More information about the llvm-commits mailing list