[PATCH] D34300: [AMDGPU] simplify add x, *ext (setcc) => addc|subb x, 0, setcc

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUInstrInfo.td:186
 
+def AMDGPUadde : SDNode<"ISD::ADDCARRY", AMDGPUAddeSubeOp, []>;
+
----------------
rampitec wrote:
> arsenm wrote:
> > Weird that the td generic nodes don't exist already for this. Looks like this was added only in April, so you should probably add the generic addcarry/subcarry to TargetSelectionDAG.td
> I'm not sure really. The intent is to gradually switch from addc/subc, so probably new td defs were not assumed.
> I think we need to use our nodes for now and remove it in the future. I can add todo here.
I have created D34423 to add addcarry and subcarry nodes.
Let's see how it goes, and it will be trivial to replace what I have defined here with those if submitted. Meanwhile I guess that is not a blocker for this change.


Repository:
  rL LLVM

https://reviews.llvm.org/D34300