[PATCH] D32658: Supports lowerInterleavedStore() in X86InterleavedAccess.

[David Kreitzer via Phabricator via llvm-commits]

DavidKreitzer added a comment.

Thanks for the fixes, Farhana. Other than a couple typos, this looks good.



================
Comment at: lib/Target/X86/X86InterleavedAccess.cpp:272
+  // Holds the indices of SVI that correspond to the starting index each
+  // interleave shuffle.
+  SmallVector<unsigned, 4> Indices;
----------------
"index each" --> "index of each"
"interleave" --> "interleaved"


================
Comment at: test/CodeGen/X86/x86-interleaved-access.ll:143
+
+define void @store_factorf64_4(<16 x double>* %ptr, <4 x double> %v0, <4 x double> %v1, <4 x double> %v2, <4 x double> %v3) {
+; AVX-LABEL: store_factorf64_4:
----------------
DavidKreitzer wrote:
> RKSimon wrote:
> > Please add these new tests to trunk now with the current codegen so your patch shows the diff.
> This a good suggestion, Farhana. Can you please do this in a separate initial patch?
Thanks! These are nice improvements in the codegen.


https://reviews.llvm.org/D32658