[PATCH] D34410: [Dominators] Add parent and sibling property verification

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added inline comments.


================
Comment at: include/llvm/Support/GenericDomTreeConstruction.h:285
+template <class GraphT>
+bool VerifyParentProperty(const DominatorTreeBaseByGraphTraits<GraphT> &DT) {
+  using BlockPtr = typename GraphT::NodeRef;
----------------
This misses one thing: It¸doesn't verify that a path exists in the first place :)

IE it should verify a path exists, then, when you remove the parent, a path no longer exists.



Repository:
  rL LLVM

https://reviews.llvm.org/D34410