[PATCH] D34402: [AArch64] Preserve register flags when promoting a load from store.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 10:01:41 PDT 2017


fhahn added inline comments.


================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:885
+      // the store and load instruction, so we can just propagate the kill flag.
+      BitExtMI->addRegisterKilled(StRt, TRI);
+    }
----------------
junbuml wrote:
> Isn't it okay to do break after this  ? 
> 
> 
Yep it should be OK, assuming there are no redundant kills later on, but then it's not the responsibility of this pass to clean that up.


https://reviews.llvm.org/D34402





More information about the llvm-commits mailing list