[PATCH] D34207: [IndVarSimplify] Add AShr exact flags using induction variables ranges.

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 20 09:36:04 PDT 2017


On Tue, Jun 20, 2017 at 9:32 AM, Dave Green via Phabricator
<reviews at reviews.llvm.org> wrote:
> dmgreen added a comment.
>
> Ping.  Anyone fancy taking a look at this, or suggesting a better place for it?

I'll review this by the end of day today.

>
> The definition of shifts past the bitwidth has recently been changed (or clarified?) to poison, not undef. I'm unsure how poison plays together with computeKnownBits, and whether the original cause of the regressions (back in https://reviews.llvm.org/rL297724) is now correct or not. It can still produce end to end compilation errors if it's reverted, which I guess is proof enough that it's needed! There may well be other ways to fix this though.
>
>
> https://reviews.llvm.org/D34207
>
>
>


More information about the llvm-commits mailing list