[PATCH] D34326: [ELF] - Support SORT_BY_INIT_PRIORITY for .ctors.*/.dtors sections in linkerscript.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I don't know if we need this, as it implements a feature that is different from what the manual says, and no one is complaining about this.



================
Comment at: ELF/LinkerScript.cpp:240
+  uint64_t ValX, ValY;
+  if (to_integer(X.trim('0'), ValX, 10) && to_integer(Y.trim('0'), ValY, 10))
+    if (ValX != ValY)
----------------
`trim()` trims the character both from both ends. That's probably not what you want.


https://reviews.llvm.org/D34326