[PATCH] D32816: [CMake] Support multi-target runtimes build

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

One question inline below.



================
Comment at: cmake/modules/LLVMExternalProjectUtils.cmake:198
   foreach(target ${ARG_EXTRA_TARGETS})
+    string(REPLACE ":" ";" target_list ${target})
+    list(GET target_list 0 target)
----------------
I'm a little confused why this is needed. Isn't `ARG_EXTRA_TARGETS` a list? This code looks like it is expecting `ARG_EXTRA_TARGETS` to be a list of lists where the inner list is colon-separated instead of semi-colon separated.


Repository:
  rL LLVM

https://reviews.llvm.org/D32816