[PATCH] D34323: Add ArgMemOnly attribute to strlen and wcslen, i.e. they only read memory (string) passed to them.

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 17 19:09:59 PDT 2017


sanjoy requested changes to this revision.
sanjoy added a comment.
This revision now requires changes to proceed.

Generally looks good, but the test isn't testing anything.



================
Comment at: test/Transforms/LICM/strlen.ll:3
+
+define void @test(i64* noalias %loc, i8* noalias %a) {
+; CHECK-LABEL: @test
----------------
You're not running this through `FileCheck` at all.  Look at the other LICM tests.


https://reviews.llvm.org/D34323





More information about the llvm-commits mailing list