[PATCH] D34317: [Dominators] Move IDoms out of DominatorTreeBase and put them in SNCAInfo

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 22:24:37 PDT 2017

kuhar added a comment.

In https://reviews.llvm.org/D34317#783154, @dberlin wrote:

> where else is getNodeForBlock used? Because requiring you pass a temporary thing that exists only during construction is ... weird.
> Are we sure it actually belongs as part of dominatortreebase?

It is used only in Calculate and I doesn't make much sense to keep it DominatorTreeBase.

My plan was to make a builder class that would run Semi-NCA and manage all of the temporaries. This would be probably to much to put in one review, so I tried to split it up into a series of small patches that move build-related temporaries out of the main DominatorTreeBase class.

This is the last commit that moves that data out of DTB and I wanted to structure whole thing better in a new patch -- so that DTB won't be responsible for the tree construction.



More information about the llvm-commits mailing list