[PATCH] D34307: Have writeCOFFWriter return Expected<unique_ptr>.

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 19:02:17 PDT 2017


ecbeckmann added inline comments.


================
Comment at: llvm/lib/Object/WindowsResource.cpp:312-314
+  WindowsResourceCOFFWriter(const WindowsResourceCOFFWriter &) = delete;
+  WindowsResourceCOFFWriter &
+  operator=(const WindowsResourceCOFFWriter &) = delete;
----------------
ruiu wrote:
> Do you have to explicitly delete these copy ctors?
oh sorry, i meant to remove that


https://reviews.llvm.org/D34307





More information about the llvm-commits mailing list