[PATCH] D31437: AMDGPU/NFC: Move amdgpu code object metadata to support

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

The dump format here randomly breaks because
include/llvm/IR/ModuleSummaryIndexYAML.h says:

  LLVM_YAML_IS_SEQUENCE_VECTOR(std::string)

contradicting lib/Support/AMDGPUCodeObjectMetadata.cpp:

  LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR(std::string)

this violates the C++ ODR rule. In practice the linker seems to pick the "wrong" specialization for me sometimes producing non-flow output for the Printf: part. Could you fix this? (I tried to do so, but for some reason I don't understand it moves the sizes or offset in some ELF data around in a testcase which I don't fully understand).


Repository:
  rL LLVM

https://reviews.llvm.org/D31437